On Fri, Sep 25, 2009 at 22:19, Song, Barry wrote: > From: [email protected] on behalf of Mike > Frysinger > On Thu, Sep 24, 2009 at 05:48, <[email protected]> wrote: >> +static struct i2c_driver adau1371_i2c_driver = { >> + .driver = { >> + .name = "adau1371 I2C Codec", >> + .owner = THIS_MODULE, >> + }, >> + .probe = adau1371_i2c_probe, >> + .remove = adau1371_i2c_remove, >> + .id_table = adau1371_i2c_id, >> +}; >> >>the .name field here seems a little non-standard. shouldnt it be >>"adau1371-i2c" ? > > Mark will require it to be "adau1371", not "adau1371-i2c".
that depends on whether the adau1371 has multiple interfaces. my reading of the source code was that it can be hooked up by something other than i2c. if it is only i2c, then the #ifdef handling needs to be dropped and the Kconfig should be updated to depend on i2c. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
