On Mon, 2009-09-28 at 16:37 -0400, Mike Frysinger wrote:
> On Mon, Sep 28, 2009 at 05:23,  <[email protected]> wrote:
> > Revision 7490 Author gyang Date 2009-09-28 05:23:05 -0400 (Mon, 28 Sep 2009)
> >
> > Log Message
> >
> > Add define of trace_buffer_init
> >
> > Modified Paths
> >
> > trunk/arch/blackfin/include/asm/trace.h
> >
> > Diff
> >
> > Modified: trunk/arch/blackfin/include/asm/trace.h (7489 => 7490)
> >
> > +#define trace_buffer_init() \
> > +   do { \
> > +           bfin_write_TBUFCTL(BFIN_TRACE_INIT); \
> > +   } while (0)
> 
> not much point in using a do{...}while since it's only one statement
> 
> do we actually need this ?  the init is done in asm code, not C code,
True. Adding it because I used it in task [#4788].

> and it should only be done once.
> -mike


_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to