On Fri, Oct 16, 2009 at 05:02, Zhang, Sonic wrote: > Write to XMT_DATA8 register should be done after INT_STAT is cleared. > So, as least one sync before XMIT_DATA8 is necessary. > I will do a bit clean up. > > Yes, a SSYNC_ATOMIC() macro is better for interrupt routine usage.
Michael pointed out something not so obvious (at least to me) ... higher priority interrupts can still interrupt things, so SSYNC_ATOMIC() would only be usable if the irq handler were registered w/IRQF_DISABLED. and people really hate when you use that flag. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
