>-----Original Message----- >From: Mike Frysinger [mailto:[email protected]] >Sent: Thursday, November 26, 2009 1:47 PM >To: [email protected] >Cc: [email protected] >Subject: Re: [Linux-kernel-commits] [7883] >trunk/drivers/spi/bfin_sport_spi.c: bug[#5722] use the new >gpio cs scheme > >On Wed, Nov 25, 2009 at 22:06, <[email protected]> wrote: >> Revision 7883 Author cliff Date 2009-11-25 22:06:52 -0500 >(Wed, 25 Nov >> 2009) >> >> Log Message >> >> bug[#5722]use the new gpio cs scheme >> >> trunk/drivers/spi/bfin_sport_spi.c >> >> static void bfin_sport_spi_cs_active(struct master_data *drv_data, >> struct slave_data *chip) { >> - gpio_direction_output(chip->cs_gpio, 0); >> + if (chip->chip_select_num > MAX_CTRL_CS) >> + gpio_direction_output(chip->cs_gpio, 0); >> } > >these MAX_CTRL_CS checks make no sense at all. the CS with >the SPORT/SPI bus can only ever be GPIOs.
Not really,the sport can provide cs by itself. Cliff _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
