Title: [7910] trunk/arch/blackfin/mach-bf561/smp.c: bug [#5735] - Suggested by Mike, kernel panic when core B failed to boot.
Revision
7910
Author
adamliyi
Date
2009-12-02 05:38:05 -0500 (Wed, 02 Dec 2009)

Log Message

bug [#5735] - Suggested by Mike, kernel panic when core B failed to boot.

Modified Paths

Diff

Modified: trunk/arch/blackfin/mach-bf561/smp.c (7909 => 7910)


--- trunk/arch/blackfin/mach-bf561/smp.c	2009-12-02 10:20:59 UTC (rev 7909)
+++ trunk/arch/blackfin/mach-bf561/smp.c	2009-12-02 10:38:05 UTC (rev 7910)
@@ -80,7 +80,6 @@
 int __cpuinit platform_boot_secondary(unsigned int cpu, struct task_struct *idle)
 {
 	unsigned long timeout;
-	int ret;
 
 	/* CoreB already running?! */
 	BUG_ON((bfin_read_SICA_SYSCR() & COREB_SRAM_INIT) == 0);
@@ -102,17 +101,13 @@
 		barrier();
 	}
 
-	ret = cpu_isset(cpu, cpu_callin_map) ? 0 : -ENOSYS;
-	if (ret) {
-		cpu_clear(cpu, cpu_present_map);
-		printk(KERN_CRIT "CPU%u: processor failed to boot (%d)\n", cpu, ret);
-		free_task(idle);
-	} else
+	if (cpu_isset(cpu, cpu_callin_map)) {
 		cpu_set(cpu, cpu_online_map);
-
-	/* release the lock and let coreb run */
-	spin_unlock(&boot_lock);
-	return ret;
+		/* release the lock and let coreb run */
+		spin_unlock(&boot_lock);
+		return 0;
+	} else
+		panic("CPU%u: processor failed to boot\n", cpu);
 }
 
 void __init platform_request_ipi(irq_handler_t handler)
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to