Title: [7920] trunk/drivers/serial/bfin_5xx.c: bfin_5xx: fix uninitialized warnings from gcc
Revision
7920
Author
vapier
Date
2009-12-03 17:54:40 -0500 (Thu, 03 Dec 2009)

Log Message

bfin_5xx: fix uninitialized warnings from gcc

Modified Paths


Diff

Modified: trunk/drivers/serial/bfin_5xx.c (7919 => 7920)


--- trunk/drivers/serial/bfin_5xx.c	2009-12-03 22:51:27 UTC (rev 7919)
+++ trunk/drivers/serial/bfin_5xx.c	2009-12-03 22:54:40 UTC (rev 7920)
@@ -1254,8 +1254,8 @@
 static int bfin_serial_probe(struct platform_device *pdev)
 {
 	struct resource *res;
-	struct bfin_serial_port *uart;
-	int ret;
+	struct bfin_serial_port *uart = NULL;
+	int ret = 0;
 
 	if (pdev->id < 0 || pdev->id >= BFIN_UART_NR_PORTS) {
 		dev_err(&pdev->dev, "Wrong bfin uart platform device id.\n");
@@ -1263,15 +1263,14 @@
 	}
 
 	if (bfin_serial_ports[pdev->id] == NULL) {
-		bfin_serial_ports[pdev->id] =
-			kzalloc(sizeof(struct bfin_serial_port), GFP_KERNEL);
 
-		uart = bfin_serial_ports[pdev->id];
+		uart = kzalloc(sizeof(*uart), GFP_KERNEL);
 		if (!uart) {
 			dev_err(&pdev->dev,
 				"fail to malloc bfin_serial_port\n");
 			return -ENOMEM;
 		}
+		bfin_serial_ports[pdev->id] = uart;
 
 #ifdef CONFIG_EARLY_PRINTK
 		if (!(bfin_earlyprintk_port.port.membase
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to