>-----Original Message-----
>From: Mike Frysinger [mailto:[email protected]] 
>Sent: Monday, December 21, 2009 10:46 PM
>To: [email protected]
>Cc: [email protected]
>Subject: Re: [Linux-kernel-commits] [6914] 
>trunk/drivers/usb/musb/musb_gadget.c: bug[#5269], bug[#5268], 
>bug[ #5264]correct dma address for tx
>
>On Wed, Sep 16, 2009 at 17:51, Mike Frysinger wrote:
>> On Fri, Jul 3, 2009 at 02:29,  <[email protected]> wrote:
>>> Revision 6914 Author cliff Date 2009-07-03 01:29:35 -0500 (Fri, 03 
>>> Jul 2009)
>>>
>>> Log Message
>>>
>>> bug[#5269],bug[#5268],bug[#5264]correct dma address for tx
>>>
>>> Modified Paths
>>>
>>> trunk/drivers/usb/musb/musb_gadget.c
>>>
>>> Diff
>>>
>>> Modified: trunk/drivers/usb/musb/musb_gadget.c (6913 => 6914)
>>>
>>> --- trunk/drivers/usb/musb/musb_gadget.c      2009-07-03 
>06:26:46 UTC 
>>> (rev 6913)
>>> +++ trunk/drivers/usb/musb/musb_gadget.c      2009-07-03 
>06:29:35 UTC 
>>> +++ (rev 6914)
>>> @@ -318,7 +318,7 @@
>>>                       use_dma = use_dma && c->channel_program(
>>>                                       musb_ep->dma, 
>>> musb_ep->packet_sz,
>>>                                       musb_ep->dma->desired_mode,
>>> -                                     request->dma,
>>> +                                     request->dma + 
>request->actual,
>>>                                       
>(musb_ep->dma->desired_mode == 
>>> 0)
>>>                                       ? request_size
>>>                                       : (request_size -
>>
>> is this fix good for everyone, or is this part of our workaround for 
>> anomaly 05000450 ?

It's an obvious mistake.DMA may need to be kicked off several times to complete 
a transfer,so,DMA must start from the base plus length that has been 
transferred.

Cliff 
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to