>-----Original Message----- >From: Mike Frysinger [mailto:[email protected]] >Sent: Wednesday, January 20, 2010 11:42 AM >To: Song, Barry >Cc: [email protected]; >[email protected] >Subject: Re: [Linux-kernel-commits] [8201] >trunk/arch/blackfin/Kconfig: fixtypo > >On Tue, Jan 19, 2010 at 22:27, Song, Barry wrote: >>From: [email protected] >>>On Tue, Jan 19, 2010 at 22:21, <[email protected]> wrote: >>>> Revision 8201 Author bhsong Date 2010-01-19 22:21:32 -0500 >>>(Tue, 19 Jan >>>> 2010) >>>> >>>> Log Message >>>> >>>> fix typo >>>> >>>> Modified: trunk/arch/blackfin/Kconfig (8200 => 8201) >>>> >>>> @@ -403,7 +403,7 @@ >>>> config ROM_BASE >>>> hex "Kernel ROM Base" >>>> depends on ROMKERNEL >>>> - default "0x20080040" >>>> + default "0x20040040" >>> >>>this isnt a typo. some of our boards have 512kB u-boot images (like >>>the BF548-EZKIT), so a 256kB size wont work for all boards. a 512kB >>>default will work for all our boards. >> >> Then 256K will be wasted on many boards. And the address >will not match >> with partition tables in board files too. > >it's a config option, so the waste doesnt really matter. anyone who >really cares about that can just as easily change their .config. the >partition tables is annoying though ... so while it might work for >more boards, it still doesnt work for all of them. not sure if this >can be cleanly resolved since we cant put the size into the defconfig >(since no boards default to ROM enabled). Even though I think "default" should be for "most", I agree your opinion too. And the config is repeating partition table in board files, difficult to get cleanly resolved.
>-mike > _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
