On Thu 11 Mar 2010 23:24, [email protected] pondered:
> Revision
> 8451<http://blackfin.uclinux.org/gf/project/linux-kernel/scmsvn/?action=browse&path=/&view=rev&root=linux-kernel&revision=8451>
> Author
> gyang<http://blackfin.uclinux.org/gf/user/gyang/>
> Date
> 2010-03-11 23:24:21 -0500 (Thu, 11 Mar 2010)
> Log Message
> 
> [!no_src_qa!]Fix bug [#5955]<http://blackfin.uclinux.org/gf/tracker/5955>, 
> SMP kernel build failed at arch/blackfin/kernel/bfin_ksyms.o, add 
> [!no_src_qa!]to avoid warning about the volatile
> 
> Modified Paths
> 
>  *   trunk/arch/blackfin/include/asm/cacheflush.h
>  *   trunk/arch/blackfin/include/asm/spinlock.h
> 
> Diff
> Modified: trunk/arch/blackfin/include/asm/cacheflush.h (8450 => 8451)
> 
> 
> --- trunk/arch/blackfin/include/asm/cacheflush.h        2010-03-11 20:10:35 
> UTC (rev 8450)
> +++ trunk/arch/blackfin/include/asm/cacheflush.h        2010-03-12 04:24:21 
> UTC (rev 8451)
> @@ -11,6 +11,7 @@
> 
>  #include <asm/blackfin.h>      /* for SSYNC() */
>  #include <asm/sections.h>      /* for _ramend */
> +#include <asm/smp.h>

Did you test this on a non-SMP before committing? It breaks for me...

  CC      init/main.o
In file included from 
/home/rgetz/blackfin/trunk/uClinux-dist/linux-2.6.x/arch/blackfin/include/asm/cacheflush.h:14,
                 from include/asm-generic/io.h:15,
                 from 
/home/rgetz/blackfin/trunk/uClinux-dist/linux-2.6.x/arch/blackfin/include/asm/io.h:63,
                 from include/linux/clocksource.h:19,
                 from include/linux/clockchips.h:13,
                 from include/linux/tick.h:9,
                 from init/main.c:46:
/home/rgetz/blackfin/trunk/uClinux-dist/linux-2.6.x/arch/blackfin/include/asm/smp.h:16:22:
 error: mach/smp.h: No such file or directory
/home/rgetz/blackfin/trunk/uClinux-dist/linux-2.6.x/arch/blackfin/include/asm/smp.h:18:1:
 warning: "raw_smp_processor_id" redefined
In file included from include/linux/topology.h:33,
                 from include/linux/gfp.h:7,
                 from include/linux/kmod.h:22,
                 from include/linux/module.h:13,
                 from init/main.c:13:
include/linux/smp.h:124:1: warning: this is the location of the previous 
definition
make[1]: *** [init/main.o] Error 1

_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to