On Thu, Apr 1, 2010 at 22:26, <[email protected]> wrote: > if (data & AD7414_T_SIGN) > - data = data&(~AD7414_T_SIGN) - AD7414_T_SIGN; > + data = (data&(~AD7414_T_SIGN)) - AD7414_T_SIGN;
seems like it should (cosmetically) be: data = (data & ~AD7414_T_SIGN) - AD7414_T_SIGN; although at a quick glance, this code doesnt seem to make much sense without understanding what is going on. data starts off as an apparent bit field, but then gets masked and subtracted ? or are you trying to implement saturation ? -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
