On Wed, May 26, 2010 at 04:46, Hennerich, Michael wrote: > Mike Frysinger wrote on 2010-05-26: >> 2010/5/26 Hennerich, Michael : >>> Song, Barry wrote on 2010-05-26: >>>> I don't think that fits with spi spec. For spi, changing CS means two >>>> different spi_message in one spi_transfer. You should use two >>>> spi_message with cs_change=1 for those devices. Thanks barry >>> >>> This means we can drop the bfin_spi_adc driver and remove the >> autobuffer DMA hack from the SPI bus driver as well. >> >> but does this address the touchscreen parts ? > > Well that checkin is missing a part that addresses the boards resources. > Take a look at struct spi_board_info. > Every device that doesn't set .mode uses SPI_MODE_0 or explicitly sets MODE2 > or MODE0, and doesn't declare an GPIO SSEL is broken.
i still think it sucks we block what the hardware can support, but i commented in the bug rather than e-mail: http://blackfin.uclinux.org/gf/tracker/5903 to fix our resources, i think we just need to change it from using the pin as a peripheral CS to a GPIO ? -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
