[Linux-kernel-commits] [8854] trunk/drivers/input/touchscreen/ad7877.c: [#6017] Implement EV_KEY: BTN_TOUCH reporting on AD7879/AD7877 touch

[hennerich]

Title: [8854] trunk/drivers/input/touchscreen/ad7877.c: [#6017] Implement EV_KEY:BTN_TOUCH reporting on AD7879/AD7877 touch

Revision

8854

Author

hennerich

Date

2010-05-26 09:32:00 -0400 (Wed, 26 May 2010)

Log Message

[#6017] Implement EV_KEY:BTN_TOUCH reporting on AD7879/AD7877 touch
screen drivers
Some input users such as Android or X require BTN_TOUCH events.
Implement EV_KEY:BTN_TOUCH and make sure that the release event 
is not erroneous scheduled without a preceding valid touch.

Modified Paths

trunk/drivers/input/touchscreen/ad7877.c

Diff

Modified: trunk/drivers/input/touchscreen/ad7877.c (8853 => 8854)

--- trunk/drivers/input/touchscreen/ad7877.c	2010-05-26 12:15:41 UTC (rev 8853)
+++ trunk/drivers/input/touchscreen/ad7877.c	2010-05-26 13:32:00 UTC (rev 8854)
@@ -333,7 +333,7 @@
 	return status ? : sample;
 }
 
-static void ad7877_rx(struct ad7877 *ts)
+static int ad7877_rx(struct ad7877 *ts)
 {
 	struct input_dev *input_dev = ts->input;
 	unsigned Rt;
@@ -360,11 +360,17 @@
 		Rt /= z1;
 		Rt = (Rt + 2047) >> 12;
 
+		if (!timer_pending(&ts->timer))
+			input_report_key(input_dev, BTN_TOUCH, 1);
+
 		input_report_abs(input_dev, ABS_X, x);
 		input_report_abs(input_dev, ABS_Y, y);
 		input_report_abs(input_dev, ABS_PRESSURE, Rt);
 		input_sync(input_dev);
+		return 0;
 	}
+
+	return -EINVAL;
 }
 
 static inline void ad7877_ts_event_release(struct ad7877 *ts)
@@ -372,6 +378,7 @@
 	struct input_dev *input_dev = ts->input;
 
 	input_report_abs(input_dev, ABS_PRESSURE, 0);
+	input_report_key(input_dev, BTN_TOUCH, 0);
 	input_sync(input_dev);
 }
 
@@ -413,11 +420,9 @@
 	struct ad7877 *ts = _ts;
 
 	spin_lock_irq(&ts->lock);
-
-	ad7877_rx(ts);
+	if (!ad7877_rx(ts))
+		mod_timer(&ts->timer, jiffies + TS_PEN_UP_TIMEOUT);
 	ts->pending = 0;
-	mod_timer(&ts->timer, jiffies + TS_PEN_UP_TIMEOUT);
-
 	spin_unlock_irq(&ts->lock);
 }
 
@@ -729,6 +734,8 @@
 	input_dev->phys = ts->phys;
 	input_dev->dev.parent = &spi->dev;
 
+	__set_bit(EV_KEY, input_dev->evbit);
+	__set_bit(BTN_TOUCH, input_dev->keybit);
 	__set_bit(EV_ABS, input_dev->evbit);
 	__set_bit(ABS_X, input_dev->absbit);
 	__set_bit(ABS_Y, input_dev->absbit);

_______________________________________________
Linux-kernel-commits mailing list
Linux-kernel-commits@blackfin.uclinux.org
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits