On Sun, Jun 13, 2010 at 06:49,  <[email protected]> wrote:
> --- trunk/include/linux/bfin_mac.h
> +++ trunk/include/linux/bfin_mac.h

perhaps we should split this header since the majority of it is
internal structures

> +struct bfin_phydev_platform_data {
> +     unsigned short addr;
> +     unsigned short irq;
> +};

does this irq go to request_irq() ?  that is an unsigned int, not short ...

> +struct bfin_mii_bus_platform_data {
> +     unsigned short *mac_peripherals;

these are the pins ?  this should be const then ...
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to