-----Original Message-----
From: Song, Barry [mailto:[email protected]]
Sent: 6/24/2010 (星期四) 2:20 下午
To: Robin Getz; [email protected]
Cc: [email protected]
Subject: 答复: [Linux-kernel-commits] [8930] trunk/arch/blackfin/kernel/ptrace.c:
bug [#6070]: permit to access scratchpad sram stack gdb
-----Original Message-----
From: Robin Getz [mailto:[email protected]]
Sent: 6/24/2010 (星期四) 6:28 上午
To: [email protected]
Cc: [email protected]
Subject: Re: [Linux-kernel-commits] [8930] trunk/arch/blackfin/kernel/ptrace.c:
bug [#6070]: permit to access scratchpad sram stack gdb
On Mon 21 Jun 2010 06:19, [email protected] pondered:
> Modified: trunk/arch/blackfin/kernel/ptrace.c (8929 => 8930)
>
>
> --- trunk/arch/blackfin/kernel/ptrace.c 2010-06-21 03:21:30 UTC (rev 8929)
> +++ trunk/arch/blackfin/kernel/ptrace.c 2010-06-21 10:19:50 UTC (rev 8930)
> @@ -27,6 +27,7 @@
> #include <asm/fixed_code.h>
> #include <asm/cacheflush.h>
> #include <asm/mem_map.h>
> +#include <asm/mmu_context.h>
>
> /*
> * does not yet catch signals sent when the child dies.
> @@ -135,6 +136,13 @@
> if (start >= FIXED_CODE_START && start + len < FIXED_CODE_END)
> return 0;
>
> +#ifdef CONFIG_APP_STACK_L1
> + if (child->mm->context.l1_stack_save)
> + if (start >= (unsigned long)l1_stack_base &&
> + start + len < (unsigned long)l1_stack_base +
> l1_stack_len)
> + return 0;
> +#endif
> +
> Does this need to have the #ifdef/stack check? or should we just allow
> scratchpad all the time?
>I guess we can allow scratchpad all the time. Whether there is L1 stack
>depends on applications, not kernel.
>That means we will delete this configuration option and related references.
There is still a reason to keep APP_STACK_L1 option(L1 is shared by application
stack and exception stack):
config APP_STACK_L1
bool "Support locating application stack in L1 Scratch Memory"
default y
help
If enabled the application stack can be located in L1
scratch memory (less latency).
Currently only works with FLAT binaries.
config EXCEPTION_L1_SCRATCH
bool "Locate exception stack in L1 Scratch Memory"
default n
depends on !APP_STACK_L1
help
Whenever an exception occurs, use the L1 Scratch memory for
stack storage. You cannot place the stacks of FLAT binaries
in L1 when using this option.
If you don't use L1 Scratch, then you should say Y here.
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
