On Thu, Jun 24, 2010 at 09:47, <[email protected]> wrote:
> Added: trunk/drivers/input/touchscreen/ad7160-raw.c (0 => 8943)
>
> @@ -0,0 +1,303 @@
> +/* NOTE:
> + * It's assumed that only one instance of this driver,
> + * with only one user is running the same time.
> + * So it's ok to use global data structures
> + */
you should codify this assumption into the probe step by having it
return -EBUSY right away if there's already an instance
> +void ad7160_feed_raw(void)
> +{
> + if (ret != AD7160_RAW_JUNK_SIZE) {
> + printk(KERN_ERR "FIFO Buffer Overflow: failed to put %lu bytes,"
> + "fifo reached %d\n Resetting FIFO\n",
> + AD7160_RAW_JUNK_SIZE - ret,
> + kfifo_len(&ad7160_raw_device.fifo));
if you dont have access to the dev to do dev_xxx, then at least use
pr_err() and define pr_fmt() at the top of the file:
#define pr_fmt(fmt) "ad7160_raw: " fmt
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
