On Tue, Jun 29, 2010 at 03:35, <[email protected]> wrote: > Revision 8950 Author bhsong Date 2010-06-29 03:35:34 -0400 (Tue, 29 Jun > 2010) > > Log Message > > [!no_src_qa!] > [#5476] always execute soft reset except bf526 0.1 and later version > > Modified Paths > > trunk/arch/blackfin/kernel/reboot.c > > */ > __builtin_bfin_ssync(); > > - /* The bootrom checks to see how it was reset and will > - * automatically perform a software reset for us when > - * it starts executing after the core reset. > - */ > - /* force to execute this workaround since some chips can't > - * reset normally even though their anomaly lists don't > - * include ANOMALY_05000353 and ANOMALY_05000386. > - */ > - if (1/* ANOMALY_05000353 || ANOMALY_05000386 */) { > - /* Initiate System software reset. */ > - bfin_write_SWRST(0x7); > +#if !(defined(__ADSPBF526__) && (__SILICON_REVISION__ > 0))
this is not the way to handle things. the old code was written the way it was on purpose -- everything is to be done at the C level, not at the CPP level. so please revert this change.and use the correct style (you should only need to tweak the first if() statement). -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
