Title: [8965] trunk/drivers/video/bfin_adv7393fb.c: bfin_adv7393: convert PPI0_FS3 anomaly handling to C rather than CPP
Revision
8965
Author
vapier
Date
2010-07-02 17:01:09 -0400 (Fri, 02 Jul 2010)

Log Message

bfin_adv7393: convert PPI0_FS3 anomaly handling to C rather than CPP

Modified Paths


Diff

Modified: trunk/drivers/video/bfin_adv7393fb.c (8964 => 8965)


--- trunk/drivers/video/bfin_adv7393fb.c	2010-07-02 20:58:13 UTC (rev 8964)
+++ trunk/drivers/video/bfin_adv7393fb.c	2010-07-02 21:01:09 UTC (rev 8965)
@@ -402,18 +402,15 @@
 	fbdev->line_len =
 	    fbdev->modes[mode].xres * (fbdev->modes[mode].bpp / 8);
 
-#if defined(BF533_FAMILY)
-	/* This implicitly covers ANOMALY_05000400
-	 * PPI Does Not Start Properly In Specific Mode
-	 */
-	if (ANOMALY_05000400 && gpio_request(P_IDENT(P_PPI0_FS3), "PPI0_FS3")) {
-		dev_err(&client->dev, "PPI0_FS3 GPIO request failed\n");
-		return -EBUSY;
+	/* Workaround "PPI Does Not Start Properly In Specific Mode" */
+	if (ANOMALY_05000400) {
+		if (gpio_request(P_IDENT(P_PPI0_FS3), "PPI0_FS3")) {
+			dev_err(&client->dev, "PPI0_FS3 GPIO request failed\n");
+			return -EBUSY;
+		}
+		gpio_direction_output(P_IDENT(P_PPI0_FS3), 0);
 	}
 
-	gpio_direction_output(P_IDENT(P_PPI0_FS3), 0);
-#endif
-
 	if (peripheral_request_list(ppi_req, DRIVER_NAME)) {
 		dev_err(&client->dev, "requesting PPI peripheral failed\n");
 		ret = -EFAULT;
@@ -734,9 +731,8 @@
 	fb_dealloc_cmap(&fbdev->info.cmap);
 	kfree(fbdev->info.pseudo_palette);
 
-#if defined(BF533_FAMILY)
-	gpio_free(P_IDENT(P_PPI0_FS3));	/* FS3 */
-#endif
+	if (ANOMALY_05000400)
+		gpio_free(P_IDENT(P_PPI0_FS3));	/* FS3 */
 	peripheral_free_list(ppi_req);
 	kfree(fbdev);
 
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to