On Wed, Jul 7, 2010 at 23:40, Song, Barry wrote: > From: Mike Frysinger [mailto:[email protected]] >> On Wed, Jul 7, 2010 at 23:12, <[email protected]> wrote: >>> +#if defined(CONFIG_SND_BF5XX_SOC_AD183X) || >>> defined(CONFIG_SND_BF5XX_SOC_AD183X_MODULE) >>> + bfin_write_FIO0_DIR(bfin_read_FIO0_DIR() | (1 << 15)); >>> + bfin_write_FIO0_FLAG_S(1 << 15); >>> + SSYNC(); >> >>use the standard gpio API please > > These are in board files. And just follow the existing style.
being in a boards file is not an excuse for not using the proper API. neither is existing code that too is broken. it should also have proper documentation explaining what exactly it's doing and why. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
