On Mon, Jul 26, 2010 at 07:05, <[email protected]> wrote: > Log Message > > fix some small problem to make adau1761 can work now.
when you make commits, please observe some basic rules: - prefix the commit message with a short identifier to narrow down what you're working on (so like "sigma firmware:" or "adau1761:") - include information on what you're actually fixing, how you're fixing it, and anything else relevant. i cant take this change and send it upstream with "fix some small problem". the maintainers would reject that in a heart beat. - split your commits up into logical pieces. so this should have been one commit to the sigma firmware driver and a different commit to the adau1761 driver. > @@ -30,7 +30,8 @@ > if (ssfw->fw->size < ssfw->pos + len) > return -EINVAL; > ret = i2c_master_send(client, (void *)&sa->addr, len); > - len -= 2; the length field is currently defined as including the two byte i2c address. so why is this line being removed ? > +/* > + * read ADAU1761 hw register and update cache > + */ > +static int adau1761_read_reg_byte(struct snd_soc_codec *codec, > + unsigned int reg) > ... > - if (codec->hw_read(codec, ADAU_DSP_ENA) != 0x01) > + if (adau1761_read_reg_byte(codec, ADAU_DSP_ENA) != 0x01) if this is a generic i2c hook func for this device driver, then shouldnt you still be using the hw function pointers ? -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
