Bob Liu wrote on 2010-08-02:
> On Mon, Aug 2, 2010 at 12:16 PM, Mike Frysinger <[email protected]>
> wrote:
>> On Mon, Aug 2, 2010 at 00:00,  <[email protected]> wrote:
>>> Revision 9034 Author lliubbo Date 2010-08-02 00:00:15 -0400 (Mon,
>>> 02 Aug
>>> 2010)
>>>
>>> Log Message
>>>
>>> Add hibernate wakeup from USB support.
>>> If a USB_DP,USB_DM or USB_VBUS edge is detected, wakeup event is
>>> generated. Set USBWE bit to enable it wakeup the processor.
>>> I have tested it on BF548-0.2.
>>>
>>> Modified: trunk/arch/blackfin/Kconfig (9033 => 9034)
>>>
>>> +config PM_BFIN_WAKE_USB
>>> +     bool "Allow Wake-Up from USB"
>>> +     depends on PM && (BF54x || BF52x)
>>> +     default n
>>> +     help
>>> +       Enable USB Wake-Up (Voltage Regulator Power-Up) (all
>>> +processors
>>> +       with USB support). This option sets the usb wake-up enable
>>> +(USBWE)
>>> +       control bit to enable wake-up upon detection of a usb
>>> +USB_DM,USB_DP
>>> +       or USB_VBUS edge.
>>>
>>> Modified: trunk/arch/blackfin/mach-common/pm.c (9033 => 9034)
>>>
>>>  #ifdef CONFIG_PM_BFIN_WAKE_GP
>>>       wakeup |= GPWE;
>>>  #endif
>>> +#ifdef CONFIG_PM_BFIN_WAKE_USB
>>> +     wakeup |= USBWE;
>>> +#endif
>>
>> i dont think this is correct.  the existing set_irq_wake() framework
>> should already work fine and from what i can see, the musb driver
>> already supports it.
>
> Sorry, I have rollback it.
>

In my forum post I outlined this before:

http://blackfin.uclinux.org/gf/project/uclinux-dist/forum/?_forum_action=MessageReply&message_id=91918&action=ForumBrowse

Based on the comment in musb_core.c this stuff needs to be tested.
And fixed in case it doesn't work.

Greetings,
Michael

Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 
Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif

_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to