On Thu, Sep 16, 2010 at 23:46, <[email protected]> wrote: > Modified: trunk/drivers/spi/spi_bfin5xx.c (9144 => 9145) > > drv_data->len = transfer->len; > cr_width = 0; > drv_data->ops = &bfin_transfer_ops_u8; > - } else { > + } else if (bits_per_word == 16) { > drv_data->n_bytes = 2; > drv_data->len = (transfer->len) >> 1; > cr_width = BIT_CTL_WORDSIZE; > drv_data->ops = &bfin_transfer_ops_u16; > + } else { > + dev_err(&drv_data->pdev->dev, "transfer: unsupported > bits_per_word\n"); > + return; > }
i dont think this works. look at how error checking is done earlier in this function. i'm guessing that simply returning will hang things or not properly return errors to the caller. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
