>-----Original Message----- >From: [email protected] [mailto:[email protected]] On >Behalf Of Mike Frysinger >Sent: Friday, October 22, 2010 2:08 PM >To: Zhang, Sonic >Cc: [email protected] >Subject: Re: [Linux-kernel-commits] [9270] trunk: netdev: >bfin_mac: let boards set vlan masks > >On Fri, Oct 22, 2010 at 02:05, Zhang, Sonic wrote: >> You patch should work, although it is not necessary to set >VLAN2 to ETH_P_8021Q when vlan2_mask is empty. > >well, we dont know the state of the MMR before the driver executes. >and my quick reading of the HRM says that these vlan masks are >always applied. so it shouldnt be harmful if we program it >all the time right ?
Yes, it is harmless. > >> But, did you also update the board file of bf518-ezbrd as well? > >i will once you like what i've committed :) -mike > Thanks Sonic _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
