Title: [9756] trunk/arch/blackfin: Blackfin: bf54x: re-enable anomaly 05000353 for all revs
- Revision
- 9756
- Author
- vapier
- Date
- 2011-03-22 21:12:47 -0400 (Tue, 22 Mar 2011)
Log Message
Blackfin: bf54x: re-enable anomaly 05000353 for all revs
Even though the anomaly sheet says that the the bootrom is fixed, tests
have shown that the fix itself does not handle all cases. So until we
get a ROM update, assume the reset code is still broken and we need to
handle things ourselves.
Modified Paths
Diff
Modified: trunk/arch/blackfin/kernel/reboot.c (9755 => 9756)
--- trunk/arch/blackfin/kernel/reboot.c 2011-03-22 20:00:04 UTC (rev 9755)
+++ trunk/arch/blackfin/kernel/reboot.c 2011-03-23 01:12:47 UTC (rev 9756)
@@ -34,11 +34,7 @@
* automatically perform a software reset for us when
* it starts executing after the core reset.
*/
- /* force to execute this workaround since some chips can't
- * reset normally even though their anomaly lists don't
- * include ANOMALY_05000353 and ANOMALY_05000386.
- */
- if (!((bfin_cpuid() == 0x27e4) && (bfin_revid() > 0))) {
+ if (ANOMALY_05000353 || ANOMALY_05000386) {
/* Initiate System software reset. */
bfin_write_SWRST(0x7);
Modified: trunk/arch/blackfin/mach-bf548/include/mach/anomaly.h (9755 => 9756)
--- trunk/arch/blackfin/mach-bf548/include/mach/anomaly.h 2011-03-22 20:00:04 UTC (rev 9755)
+++ trunk/arch/blackfin/mach-bf548/include/mach/anomaly.h 2011-03-23 01:12:47 UTC (rev 9756)
@@ -81,7 +81,11 @@
/* PLL Status Register Is Inaccurate */
#define ANOMALY_05000351 (__SILICON_REVISION__ < 1)
/* bfrom_SysControl() Firmware Function Performs Improper System Reset */
-#define ANOMALY_05000353 (__SILICON_REVISION__ < 2)
+/*
+ * Note: anomaly sheet says this is fixed with bf54x-0.2+, but testing
+ * shows that the fix itself does not cover all cases.
+ */
+#define ANOMALY_05000353 (1)
/* Regulator Programming Blocked when Hibernate Wakeup Source Remains Active */
#define ANOMALY_05000355 (__SILICON_REVISION__ < 1)
/* System Stalled During A Core Access To AMC While A Core Access To NFC FIFO Is Required */
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
