On Wed, Jun 8, 2011 at 23:09, Scott Jiang wrote:
> 2011/6/3 Mike Frysinger:
>> On Fri, Jun 3, 2011 at 19:24, Scott Jiang wrote:
>>> +static int adv7183_reset(struct v4l2_subdev *sd, u32 val)
>>> +{
>>> + int reg;
>>> +
>>> + reg = adv7183_read(sd, ADV7183_POW_MANAGE) | 0x80;
>>> + adv7183_write(sd, ADV7183_POW_MANAGE, reg);
>>> + msleep(20);
>>
>> that's a pretty long sleep. you should probably document why.
>
> if I use msleep(5), commit script check will fail
the script told you how to fix the issue. increasing it to msleep(20)
is not the answer.
the output from the script:
msleep < 20ms can sleep for up to 20ms; see
Documentation/timers/timers-howto.txt
and that file tells you:
SLEEPING FOR ~USECS OR SMALL MSECS ( 10us - 20ms):
* Use usleep_range
also, please keep replies on list
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
