2011/6/3 Mike Frysinger <[email protected]>: > On Fri, Jun 3, 2011 at 18:17, Scott Jiang <[email protected]> wrote: >> --- a/drivers/media/video/Kconfig >> +++ b/drivers/media/video/Kconfig > >> +static struct bcap_format bcap_formats[] = { > > shouldnt this be in the ppi code ? different ppi devices will have > diff capabilities wont they ? the eppi supports more stuff than the > ppi ... > > also, this should be const >
This is a map to search fortmat info, ppi can support any format, so I just give a limited map that usually we need. That's not capability. >> --- /dev/null >> +++ b/drivers/media/video/blackfin/ppi.c >> @@ -0,0 +1,266 @@ >> +#include <asm/io.h> > > linux/io.h > >> +#define regr(reg) readw((reg) + ppi_base) >> +#define regw(value, reg) writew(value, ((reg) + ppi_base)) >> + >> +#define REG_PPI_CONTROL 0x00 /* PPI Control */ >> +#define REG_PPI_STATUS 0x04 /* PPI Status */ >> +#define REG_PPI_COUNT 0x08 /* Transfer Count */ >> +#define REG_PPI_DELAY 0x0C /* Delay Count */ >> +#define REG_PPI_FRAME 0x10 /* Lines Per Frame */ > > ugh, no. include asm/bfin_ppi.h, and then use things like > bfin_read(®s->control) and bfin_write(®s->control, 0x100). > I want to write a universal driver for blackfin and arm, so I used ioremap. _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
