On Wed, Jun 22, 2011 at 06:40, Bob Liu <[email protected]> wrote:
> dma mode 0 should selected when request_size equal with musb_ep->packet_sz,
> else usbtest 2/4/6/8 will hang in gadget_zero bulk test.
>
> --- a/drivers/usb/musb/musb_gadget.c
> +++ b/drivers/usb/musb/musb_gadget.c
> @@ -375,7 +375,7 @@ static void txstate(struct musb *musb, struct
> musb_request *req)
>
>  #ifdef CONFIG_USB_INVENTRA_DMA
>               {
> -                     if (request_size < musb_ep->packet_sz)
> +                     if (request_size <= musb_ep->packet_sz)
>                               musb_ep->dma->desired_mode = 0;
>                       else
>                               musb_ep->dma->desired_mode = 1;

this is just a revert of commit d1043a2697effee3054451a9293a376bfb013e4b:
Author: Anand Gadiyar <[email protected]>
Date:   Thu Apr 2 12:07:08 2009 -0700
musb: use dma mode 1 for TX if transfer size equals maxpacket (v2)

could you start a thread on the topic with the usb guys please ?  and
be sure to cc the bfin mailing list ...
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to