-----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Mike Frysinger Sent: Thursday, June 30, 2011 1:31 PM To: Jiang, Scott Cc: [email protected] Subject: Re: [Linux-kernel-commits] [#4377] v4l2: add ppi control flags
On Wed, Jun 29, 2011 at 22:26, Jiang, Scott wrote: >> these magic numbers really need to be defines. i'll probably merge >> the toolchain/trunk/proc-defs/header-frags/regbits/ppi.h header file >> into asm/bfin_ppi.h, then you can replace all of this logic with that. > > Yes, some macros are defined in mach/defBF5xx.h, but not complete > We'd better put all these macros together. > OK, i'll try and get this done this week. in general, i'm trying to > widdle down the code in the def* and cdef* files to a more standard > asm/<peripheral>.h header. this keeps global namespace pollution > down. Some macro names are too generic, like DMA32. If it is only for a peripheral, it should have a prefix. _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
