Stephen, On Thu, 15 Oct 2015 16:19:38 -0700, Stephen Boyd wrote: > If a clock provider has #clock-cells = 1 and we call > of_clk_get_parent_name() on it we may end up returning the name > of the provider node if the provider doesn't have a > clock-output-names property. This doesn't make sense, especially > when you consider that calling of_clk_get_parent_name() on such a > node with different indices will return the same name each time. > > Let's try getting the clock from the framework via of_clk_get() > instead, and only fallback to the node name if we have a provider > with #clock-cells = 0. This way, we can't hand out the same name > for different clocks when we don't actually know their names. > > Signed-off-by: Stephen Boyd <[email protected]> > --- > drivers/clk/clk.c | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-)
Tested-by: Thomas Petazzoni <[email protected]> I tested on top of 4.3-rc5 and the Armada XP per-CPU clocks are now properly parented with their common parent "cpuclk". Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
