Hi Masami, On Thu, 2015-10-22 at 20:17 +0900, Masami Hiramatsu wrote: > Hi Tom, > > I've tested your series of the hist trigger v10 with > these testcases included in the couple of patches, which > tests following features. > > - traceon-traceoff trigger > - enable/disable_event trigger > - snapshot trigger > - stacktrace trigger > - trigger filters > > - Histogram trigger itself > - Histogram with string key > - Histogram with compound keys > - Histogram with sort key > - Histogram trigger modifiers (execname, hex, syscall) > - Multiple histograms on an event > - Named histogram > - Named histogram on multi events > > Here is the test result. > ---- > # ./ftracetest test.d/trigger/ > === Ftrace unit tests === > [1] event trigger - test event enable/disable trigger [PASS] > [2] event trigger - test trigger filter [PASS] > [3] event trigger - test histogram modifiers [PASS] > [4] event trigger - test histogram trigger [PASS] > [5] event trigger - test multiple histogram triggers [PASS] > [6] event trigger - test snapshot-trigger [PASS] > [7] event trigger - test stacktrace-trigger [PASS] > [8] event trigger - test traceon/off trigger [PASS] > > # of passed: 8 > # of failed: 0 > # of unresolved: 0 > # of untested: 0 > # of unsupported: 0 > # of xfailed: 0 > # of undefined(test bug): 0 > ---- >
Hey, this is great, thanks for creating this! I'm looking forward to moving as many of my current set of tests to your framework as I can: http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-contrib/commit/?h=tzanussi/hist-triggers-test&id=53d7d47bac3340b2160bf2a5b48268d6c7516734 I run all of the above tests manually every time I make a significant change, which is about 2 hours of solid tedious work each time through. Obviously it's about time to automate - thanks for providing the framework to finally help do that. > So I'm OK for your hist trigger series. > If you would not mind, please include these patches and my tested-by > in your series to prove your series is good :) > > Tested-by: Masami Hiramatsu <[email protected]> > Sure, I'll do that, new series coming up shortly.. Thanks, Tom > Thank you, > > > --- > > Masami Hiramatsu (2): > kselftests/ftrace : Add event trigger testcases > kselftests/ftrace: Add hist trigger testcases > > > tools/testing/selftests/ftrace/test.d/functions | 9 ++ > .../ftrace/test.d/trigger/trigger-eventonoff.tc | 64 +++++++++++++++ > .../ftrace/test.d/trigger/trigger-filter.tc | 59 ++++++++++++++ > .../ftrace/test.d/trigger/trigger-hist-mod.tc | 65 ++++++++++++++++ > .../ftrace/test.d/trigger/trigger-hist.tc | 83 > ++++++++++++++++++++ > .../ftrace/test.d/trigger/trigger-multihist.tc | 73 ++++++++++++++++++ > .../ftrace/test.d/trigger/trigger-snapshot.tc | 56 +++++++++++++ > .../ftrace/test.d/trigger/trigger-stacktrace.tc | 53 +++++++++++++ > .../ftrace/test.d/trigger/trigger-traceonoff.tc | 58 ++++++++++++++ > 9 files changed, 520 insertions(+) > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-eventonoff.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-filter.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-multihist.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-snapshot.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-stacktrace.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-traceonoff.tc > > -- > Masami HIRAMATSU > Linux Technology Research Center, System Productivity Research Dept. > Center for Technology Innovation - Systems Engineering > Hitachi, Ltd., Research & Development Group > E-mail: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
