Em Wed, Oct 14, 2015 at 12:41:23PM +0000, Wang Nan escreveu: > When failure occures in add_probe_trace_event(), args in > probe_trace_event is incomplete. Since information in it may be used > in futher, this patch frees the allocated memory and set it to NULL > to avoid dangling pointer.
Masami, can I have your Acked-by for this one? Thanks, - Arnaldo > Signed-off-by: Wang Nan <[email protected]> > Cc: Alexei Starovoitov <[email protected]> > Cc: Brendan Gregg <[email protected]> > Cc: Daniel Borkmann <[email protected]> > Cc: David Ahern <[email protected]> > Cc: He Kuang <[email protected]> > Cc: Jiri Olsa <[email protected]> > Cc: Kaixu Xia <[email protected]> > Cc: Masami Hiramatsu <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Zefan Li <[email protected]> > Cc: [email protected] > Cc: Arnaldo Carvalho de Melo <[email protected]> > Link: http://lkml.kernel.org/n/[email protected] > --- > tools/perf/util/probe-finder.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c > index bd8f03d..b1581d7 100644 > --- a/tools/perf/util/probe-finder.c > +++ b/tools/perf/util/probe-finder.c > @@ -1235,6 +1235,10 @@ static int add_probe_trace_event(Dwarf_Die *sc_die, > struct probe_finder *pf) > > end: > free(args); > + if (ret) { > + tev->nargs = 0; > + zfree(&tev->args); > + } > return ret; > } > > -- > 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
