On Saturday, October 31, 2015 at 04:33:28 AM, Brian Norris wrote:
> We should assign the MTD dev.of_node instead of the parser data field.
> This gets us the equivalent partition parser behavior with fewer special
> fields and parameter passing.
>
> Also convert several of these to mtd_device_register(), since we don't
> need the 2nd and 3rd parameters anymore.
>
> Signed-off-by: Brian Norris <computersforpe...@gmail.com>
[...]
> diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
> index e46b4e983666..b78265688075 100644
> --- a/drivers/mtd/maps/physmap_of.c
> +++ b/drivers/mtd/maps/physmap_of.c
> @@ -166,7 +166,6 @@ static int of_flash_probe(struct platform_device *dev)
> int reg_tuple_size;
> struct mtd_info **mtd_list = NULL;
> resource_size_t res_size;
> - struct mtd_part_parser_data ppdata;
> bool map_indirect;
> const char *mtd_name = NULL;
>
> @@ -310,13 +309,13 @@ static int of_flash_probe(struct platform_device
> *dev) if (err)
> goto err_out;
>
> - ppdata.of_node = dp;
> + mtd_set_of_node(info->cmtd, dp);
> part_probe_types = of_get_probes(dp);
> if (!part_probe_types) {
> err = -ENOMEM;
> goto err_out;
> }
> - mtd_device_parse_register(info->cmtd, part_probe_types, &ppdata,
> + mtd_device_parse_register(info->cmtd, part_probe_types, NULL,
Did you miss this one ?
> NULL, 0);
> of_free_probes(part_probe_types);
>
This is really good, I like to see the ppdata nonsense finally going away.
Reviewed-by: Marek Vasut <ma...@denx.de>
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
