Hi Jiri,
On Sat, Oct 31, 2015 at 12:09:46PM +0100, Jiri Olsa wrote:
> On Sat, Oct 31, 2015 at 02:15:38AM +0900, Namhyung Kim wrote:
>
> SNIP
>
> >
> > if (!rem_sq_bracket)
> > return ret;
> >
> > + if (callchain_param.value == CCVAL_COUNT) {
> > + rem_node.count = child->parent->children_count -
> > cumul_count;
> > + if (rem_node.count <= 0)
> > + return ret;
> > + }
> > +
> > new_depth_mask &= ~(1 << (depth - 1));
> > - ret += ipchain__fprintf_graph(fp, NULL, &rem_hits, depth,
> > + ret += ipchain__fprintf_graph(fp, &rem_node, &rem_hits, depth,
> > new_depth_mask, 0, total_samples,
> > left_margin);
>
> this looks like being introduced within your patchset in patch:
> perf callchain: Abstract callchain print function
>
> shouldn't it get fixed in there?
Right. I'll move it to the commit
Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
