On 12/5/06, Michal Schmidt <[EMAIL PROTECTED]> wrote:
Jaswinder Singh wrote: > Hi, > > preempt stuff SHOULD only stay in #ifdef CONFIG_PREEMP_* , but it is > messing with everyone even though not defined. > > e.g. > > 1. linux-2.6.19/kernel/spinlock.c > > Line 18: #include <linux/preempt.h> > > Line 26: preempt_disable(); > > Line 32: preempt_disable(); > > and so on .Don't worry. These compile into "do { } while (0)" (i.e. nothing) when CONFIG_PREEMPT is not set.
Yes, Compiler will remove it but this looks ugly and confusing. Why dont we use like this :- #ifdef CONFIG_PREEMPT #include <linux/preempt.h> #endif #ifdef CONFIG_PREEMPT preempt_disable(); #endif #ifdef CONFIG_PREEMPT preempt_enable(); #endif Regards, Jaswinder Singh. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
