Arnd Bergmann <[email protected]> writes: > On Tuesday 27 October 2015 12:57:57 Mans Rullgard wrote: >> --- a/arch/arm/include/debug/8250.S >> +++ b/arch/arm/include/debug/8250.S >> @@ -9,6 +9,18 @@ >> */ >> #include <linux/serial_reg.h> >> >> +#ifdef CONFIG_DEBUG_UART_8250_PALMCHIP >> + >> +#undef UART_TX >> +#undef UART_LSR >> +#undef UART_MSR >> + >> +#define UART_TX 1 >> +#define UART_LSR 7 >> +#define UART_MSR 8 >> + >> +#endif >> > > Maybe use a separate file instead of an #ifdef? > > Something like > > arch/arm/include/debug/8250-palmchip.S: > > #include <linux/serial_reg.h> > > #undef UART_TX > #undef UART_LSR > #undef UART_MSR > > #define UART_TX 1 > #define UART_LSR 7 > #define UART_MSR 8 > > #include "8250.S"
Good idea. I'll make a new patch. -- Måns Rullgård [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
