On 10/30, Viresh Kumar wrote: > dev_opp_list_lock is used everywhere to protect device and OPP lists, > but dev_pm_opp_set_sharing_cpus() is missed somehow. And instead we used > rcu-lock, which wouldn't help here as we are adding a new list_dev. > > This also fixes a problem where we have called kzalloc(..., GFP_KERNEL) > from within rcu-lock, which isn't allowed as kzalloc can sleep when > called with GFP_KERNEL. > > With CONFIG_DEBUG_ATOMIC_SLEEP set, we will see the caller vomiting. > > Fixes: 8d4d4e98acd6 ("PM / OPP: Add helpers for initializing CPU OPPs") > Reported-by: Michael Turquette <mturque...@baylibre.com> > Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> > ---
Reviewed-by: Stephen Boyd <sb...@codeaurora.org> I assume some other patch will come to fix the comment and/or add the lockdep check. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/