registering the device with NULL pointer can lead to crash, hence fixing it
Signed-off-by: Saurabh Sengar <[email protected]> --- > Andy Shevchenko wrote: > Hmm… Why not just checking it before an register attempt? I think user > is in right to know as many problems as they have at one shot, with > your patch if there are two problems the user has to try twice. Yes, taken your feedback, fixing it here in v2 as you recommended drivers/mtd/devices/phram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c index 8b66e52..46b7a8a 100644 --- a/drivers/mtd/devices/phram.c +++ b/drivers/mtd/devices/phram.c @@ -257,6 +257,9 @@ static int phram_setup(const char *val) parse_err("illegal device length\n"); } + if(!name) + return -EINVAL; + ret = register_device(name, start, len); if (!ret) pr_info("%s device: %#llx at %#llx\n", name, len, start); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
