On Tue, Nov 10, 2015 at 01:38:08PM -0500, Tejun Heo wrote: > On Tue, Nov 10, 2015 at 09:34:05PM +0300, Vladimir Davydov wrote: > > Currently, if we want to account all objects of a particular kmem cache, > > we have to pass __GFP_ACCOUNT to each kmem_cache_alloc call, which is > > inconvenient. This patch introduces SLAB_ACCOUNT flag which if passed to > > kmem_cache_create will force accounting for every allocation from this > > cache even if __GFP_ACCOUNT is not passed. > > > > This patch does not make any of the existing caches use this flag - it > > will be done later in the series. > > > > Note, a cache with SLAB_ACCOUNT cannot be merged with a cache w/o > > SLAB_ACCOUNT, i.e. using this flag will probably reduce the number of > > merged slabs even if kmem accounting is not used (only compiled in). > > Am I correct in thinking that we should eventually be able to removed > __GFP_ACCOUNT and that only caches explicitly marked with SLAB_ACCOUNT > would need to be handled by kmemcg?
Don't think so, because sometimes we want to account kmalloc. Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
