On 11/12/2015 07:10 PM, Sreekanth Reddy wrote: > Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI IO > request message, check whether TLR is enabled on the drive using > 'sas_is_tlr_enabled' API. > > Actually in the driver code, driver is using below API's > > 1. sas_enable_tlr() - to enable the TLR > 2. sas_disable_tlr() - to disable the TLR > 3. sas_is_tlr_enabled() - to check whether TLR is enabled or not. > > but in scsih_qcmd() we have missed to use sas_is_tlr_enabled() API, > instead we checking for TLR bit from flag field of driver's > 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch. > > Signed-off-by: Sreekanth Reddy <[email protected]> > --- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index d95206b..9ab77b0 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -3905,8 +3905,7 @@ scsih_qcmd(struct Scsi_Host *shost, struct scsi_cmnd > *scmd) > * We do not expose raid functionality to upper layer for warpdrive. > */ > if (!ioc->is_warpdrive && !scsih_is_raid(&scmd->device->sdev_gendev) > - && (sas_device_priv_data->flags & MPT_DEVICE_TLR_ON) && > - scmd->cmd_len != 32) > + && sas_is_tlr_enabled(scmd->device) && scmd->cmd_len != 32) > mpi_control |= MPI2_SCSIIO_CONTROL_TLR_ON; > > smid = mpt3sas_base_get_smid_scsiio(ioc, ioc->scsi_io_cb_idx, scmd); > Reviewed-by: Hannes Reinecke <[email protected]>
Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
