On 11/13/2015 02:33 PM, Marc Gonzalez wrote:
On 13/11/2015 11:58, Daniel Lezcano wrote:

The current code to initialize, register and read the clocksource is
already factored out in mmio.c via the clocksource_mmio_init function.

Factor out the code with the clocksource_mmio_init function.

Signed-off-by: Daniel Lezcano <[email protected]>
---
  drivers/clocksource/tango_xtal.c | 18 +++---------------
  1 file changed, 3 insertions(+), 15 deletions(-)

Hello Daniel,

I think you also need:

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 63c878d4d9e3..92bf3fc3e646 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -278,6 +278,7 @@ config CLKSRC_MIPS_GIC
  config CLKSRC_TANGO_XTAL
         bool
         select CLKSRC_OF
+       select CLKSRC_MMIO

  config CLKSRC_PXA
         def_bool y if ARCH_PXA || ARCH_SA1100


Otherwise, we'll get "undefined reference" link errors.

Ok, thanks for spotting that. It did not happen because the dependency was set by another driver (using COMPILE_TEST).

Will fix it.

  -- Daniel


--
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to