On 11/20/2015 03:52 AM, Christoph Hellwig wrote:
the memory leak looks real, and your fix looks corret, but I still
don't like it.
I think it's reasonable for SCSI to assume that the final put_device
fully frees the struct device including the name pointer that is
assigned entirely behind the back of the caller.
So I think the fix for this probably should be in the driver core.
Hello Christoph,
Thanks for the feedback. However, I'm not sure this can be fixed by
modifying the driver core. If scsi_host_remove() is not called the SCSI
core doesn't call put_device(&shost->shost_dev). I will post a second
version of this patch that ensures that the SCSI core always calls
put_device(&shost->shost_dev).
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
