On Fri, Nov 20 2015, Andy Shevchenko <[email protected]> wrote:
> On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: >> >> >> Why keep the variable l when it is just a synonym for the new >> parameter buflen? It is quite confusing that you change some but not >> all occurrences of l to buflen. If you want to make the diff minimal >> but still have a descriptive parameter name, just keep the 'size_t l >> = >> buflen;' assignment and don't otherwise refer to buflen. But I think >> it's better to eliminate 'l' and just change everything to >> buflen. Don't mix the two approaches, though. > > Okay, I got it for the future, though the series is already in linux- > next, so do we really need to re-hack half of it because of that? Stuff in -next isn't set in stone. I'm pretty sure Andrew can replace one set of patches with another. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
