On Tue, Nov 24, 2015 at 12:54:59PM +0100, Michal Hocko wrote: > From: Michal Hocko <[email protected]> > > zone_reclaimable_pages counts how many pages are reclaimable in > the given zone. This currently includes all pages on file lrus and > anon lrus if there is an available swap storage. We do not consider > NR_ISOLATED_{ANON,FILE} counters though which is not correct because > these counters reflect temporarily isolated pages which are still > reclaimable because they either get back to their LRU or get freed > either by the page reclaim or page migration. > > The number of these pages might be sufficiently high to confuse users of > zone_reclaimable_pages (e.g. mbind can migrate large ranges of memory at > once).
Sounds reasonable to me. Reviewed-by: Vladimir Davydov <[email protected]> Thanks, Vladimir > > Suggested-by: Johannes Weiner <[email protected]> > Signed-off-by: Michal Hocko <[email protected]> > --- > mm/vmscan.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index a4507ecaefbf..946d348f5040 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -197,11 +197,13 @@ static unsigned long zone_reclaimable_pages(struct zone > *zone) > unsigned long nr; > > nr = zone_page_state(zone, NR_ACTIVE_FILE) + > - zone_page_state(zone, NR_INACTIVE_FILE); > + zone_page_state(zone, NR_INACTIVE_FILE) + > + zone_page_state(zone, NR_ISOLATED_FILE); > > if (get_nr_swap_pages() > 0) > nr += zone_page_state(zone, NR_ACTIVE_ANON) + > - zone_page_state(zone, NR_INACTIVE_ANON); > + zone_page_state(zone, NR_INACTIVE_ANON) + > + zone_page_state(zone, NR_ISOLATED_ANON); > > return nr; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
