On Wed, 2006-12-13 at 13:12 +0100, Peter Zijlstra wrote: > Still testing this patch, but it looks good so far. > > --- > Just setting PG_dirty can cause NR_FILE_DIRTY to underflow > which is bad (TM). > > Use set_page_dirty() which will do the right thing.
Actually, I'd prefer to have it do the right thing by getting rid of that call to test_clear_page_dirty() inside invalidate_inode_pages2_range(). That is causing loss of data integrity, and is what is causing us to have to hack NFS in the first place. Cheers Trond > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > --- > fs/nfs/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6-git2/fs/nfs/file.c > =================================================================== > --- linux-2.6-git2.orig/fs/nfs/file.c 2006-12-13 12:54:55.000000000 +0100 > +++ linux-2.6-git2/fs/nfs/file.c 2006-12-13 12:55:12.000000000 +0100 > @@ -321,7 +321,7 @@ static int nfs_release_page(struct page > if (!(gfp & __GFP_FS)) > return 0; > /* Hack... Force nfs_wb_page() to write out the page */ > - SetPageDirty(page); > + set_page_dirty(page); > return !nfs_wb_page(page->mapping->host, page); > } > > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
