On Tue, Dec 15, 2015 at 06:14:19PM +0000, Simmons, James A. wrote:
>
> >> struct libcfs_ioctl_hdr {
> >> __u32 ioc_len;
> >> @@ -87,6 +88,13 @@ do { \
> >> data.ioc_hdr.ioc_len = sizeof(data); \
> >> } while (0)
> >>
> >> +#define LIBCFS_IOC_INIT_V2(data, hdr) \
> >> +do { \
> >> + memset(&(data), 0, sizeof(data)); \
> >> + (data).hdr.ioc_version = LIBCFS_IOCTL_VERSION2; \
> >> + (data).hdr.ioc_len = sizeof(data); \
> >> +} while (0)
> >> +
> >
> >Do we really need this?
>
> Would you be okay if this was a inline function? This is used by user
> land and kernel space code.
Then your code is broken, please never do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
