On 08 December 2015 13:56, Lee Jones wrote: > To: Geert Uytterhoeven > Subject: Re: [PATCH] mfd: da9063: Allow modular build > > On Mon, 07 Dec 2015, Geert Uytterhoeven wrote: > > > Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which > > allows to decrease size of multi-platform kernels (e.g. > > multi_v7_defconfig). > > > > Signed-off-by: Geert Uytterhoeven <[email protected]> > > --- > > drivers/mfd/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > The DA9063 driver appears to contain all module code. In fact, I'm > surprised that it wasn't enabled for tristate in the first place. > > In any case, it would be good to get a Reviewed/Acked-by from one of > the Dialog guys.
Yes. Without this we cannot load any of the sub-devices as modules for the DA9063. Sorry this has taken so long for me to look at. Acked-by: Steve Twiss <[email protected]> Regards, Steve > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index 4d92df6ef9fe92ac..527ee7168617c933 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -211,7 +211,7 @@ config MFD_DA9062 > > of the device. > > > > config MFD_DA9063 > > - bool "Dialog Semiconductor DA9063 PMIC Support" > > + tristate "Dialog Semiconductor DA9063 PMIC Support" > > select MFD_CORE > > select REGMAP_I2C > > select REGMAP_IRQ > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
