Re: [PATCH 4/4] PCI: rcar: Add Gen2 PHY setup to pcie-rcar

[Wolfram Sang]

> +     rcar_pci_write_reg(pcie, 0x000f0030, GEN2_PCIEPHYADDR);
> +     rcar_pci_write_reg(pcie, 0x00381203, GEN2_PCIEPHYDATA);
> +     rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL);
> +     rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL);
> +
> +     rcar_pci_write_reg(pcie, 0x000f0054, GEN2_PCIEPHYADDR);
> +     /* The following value is for DC connection, no termination resistor */
> +     rcar_pci_write_reg(pcie, 0x13802007, GEN2_PCIEPHYDATA);
> +     rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL);
> +     rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL);

I'd vote for a comment saying where these magic values come from, i.e.
which manual, which chapter, etc...

signature.asc
Description: Digital signature