Hi Joe,
No this is not done with checkpatch.pl I just used it to verify that my changes
are correct. I was wondering why that “type” pointer threw errors since it
looks fine to me the way it was declared. This “type*” is just present in few
of the files I can just redo those changes and send the patch again.
Thanks, Sasa
{
name: Bogicevic Sasa
phone: +381606006200
}
> On Dec 27, 2015, at 18:21, Joe Perches <[email protected]> wrote:
>
> On Sun, 2015-12-27 at 08:40 -0800, Bogicevic Sasa wrote:
>> This patch fixes all whitespace issues( missing or needed whitespace) in
>> all files in drivers/pci folder. Code is compiled with allyesconfig
>> before and after code changes and objects are recorded and checked with
>> objdiff and they are not changed after this commit.
> []
>> diff --git a/drivers/pci/access.c b/drivers/pci/access.c
> []
>> @@ -25,9 +25,9 @@ DEFINE_RAW_SPINLOCK(pci_lock);
>> #define PCI_word_BAD (pos & 1)
>> #define PCI_dword_BAD (pos & 3)
>>
>> -#define PCI_OP_READ(size,type,len) \
>> +#define PCI_OP_READ(size, type, len) \
>> int pci_bus_read_config_##size \
>> - (struct pci_bus *bus, unsigned int devfn, int pos, type *value) \
>> + (struct pci_bus *bus, unsigned int devfn, int pos, type * value)
>> \
>> { \
>> int res; \
>> unsigned long flags; \
>> @@ -40,7 +40,7 @@ int pci_bus_read_config_##size \
>> return res; \
>> }
>
> When the first entry I look at is improper, I wonder
> about the rest.
>
> Was this done with checkpatch --types=spacing --fix ?
>
> If so, because checkpatch is brainless, you need to
> visually verify each change.
>
> This "type" use is a macro argument indicating
> what actual c90 type is being used in a function.
>
> The original code is nominally correct, but checkpatch
> doesn't know that "type" is not a variable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
