Hi Milo, On Mon, 4 Jan 2016 13:28:25 +0900 Milo Kim <[email protected]> wrote:
> Atmel AIC has common structure for SMR (Source Mode Register). > > bit[6:5] Interrupt source type > bit[2:0] Priority level > Other bits are unused. > > To update new priority value, bit[2:0] should be cleared first and then > new priority level can be written. However, aic_common_set_priority() > helper clears source type bits instead of priority bits. > This patch fixes wrong mask bit operation. > > Cc: Thomas Gleixner <[email protected]> > Cc: Jason Cooper <[email protected]> > Cc: Marc Zyngier <[email protected]> > Cc: Alexandre Belloni <[email protected]> > Cc: Boris BREZILLON <[email protected]> > Cc: Ludovic Desroches <[email protected]> > Cc: Nicolas Ferre <[email protected]> > Cc: [email protected] > Signed-off-by: Milo Kim <[email protected]> Acked-by: Boris Brezillon <[email protected]> Can you also add Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Cc: [email protected] #v3.17+ Thanks, Boris > --- > drivers/irqchip/irq-atmel-aic-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-atmel-aic-common.c > b/drivers/irqchip/irq-atmel-aic-common.c > index b12a5d5..37199b9 100644 > --- a/drivers/irqchip/irq-atmel-aic-common.c > +++ b/drivers/irqchip/irq-atmel-aic-common.c > @@ -86,7 +86,7 @@ int aic_common_set_priority(int priority, unsigned *val) > priority > AT91_AIC_IRQ_MAX_PRIORITY) > return -EINVAL; > > - *val &= AT91_AIC_PRIOR; > + *val &= ~AT91_AIC_PRIOR; > *val |= priority; > > return 0; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
