On Sun, Jan 03, 2016 at 11:02:56AM +0100, SF Markus Elfring wrote: > From: Markus Elfring <[email protected]> > Date: Sun, 3 Jan 2016 10:50:11 +0100 > > Reduce the scope for the local variable "def_discipline" to one branch > of an if statement. > > Signed-off-by: Markus Elfring <[email protected]> > --- > drivers/s390/net/qeth_core_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/s390/net/qeth_core_main.c > b/drivers/s390/net/qeth_core_main.c > index 54fde2e..3261977 100644 > --- a/drivers/s390/net/qeth_core_main.c > +++ b/drivers/s390/net/qeth_core_main.c > @@ -5638,9 +5638,10 @@ static int qeth_core_set_online(struct ccwgroup_device > *gdev) > { > struct qeth_card *card = dev_get_drvdata(&gdev->dev); > int rc; > - int def_discipline; > > if (!card->discipline) { > + int def_discipline; > + > if (card->info.type == QETH_CARD_TYPE_IQD) > def_discipline = QETH_DISCIPLINE_LAYER3;
Same here: I don't think we want to start with patches like this. This going to be a never ending story without much benefit. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
