On Wed, 23 Dec 2015 22:08:41 +0900 Namhyung Kim <[email protected]> wrote:
> The print_event_field() and print_event_fields() are to print basic > information of a given field or event without the print format. They'll > be used by dynamic sort keys later. Hi Namhyung, > diff --git a/tools/lib/traceevent/event-parse.h > b/tools/lib/traceevent/event-parse.h > index 6fc83c7edbe9..600c73277a6f 100644 > --- a/tools/lib/traceevent/event-parse.h > +++ b/tools/lib/traceevent/event-parse.h > @@ -705,6 +705,10 @@ struct cmdline *pevent_data_pid_from_comm(struct pevent > *pevent, const char *com > struct cmdline *next); > int pevent_cmdline_pid(struct pevent *pevent, struct cmdline *cmdline); > > +void print_event_field(struct trace_seq *s, void *data, > + struct format_field *field); > +void print_event_fields(struct trace_seq *s, void *data, > + int size __maybe_unused, struct event_format *event); I'm fine with the patch, but can you change the function names to be less generic, as this will now be part of a library (that I hope will become something supplied by distros soon). Like: pevent_print_field(); and pevent_print_fields(); Thanks! -- Steve > void pevent_event_info(struct trace_seq *s, struct event_format *event, > struct pevent_record *record); > int pevent_strerror(struct pevent *pevent, enum pevent_errno errnum, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
